Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1aa9b14baed4
Choose a base ref
...
head repository: opal/opal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6f5017080b0e
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Jul 2, 2015

  1. Implement BasicObject#!=

    vais committed Jul 2, 2015
    Copy the full SHA
    e0ad22d View commit details
  2. Merge pull request #971 from vais/implement-basic-object-not-equal-me…

    …thod
    
    Implement BasicObject#!=
    elia committed Jul 2, 2015

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    6f50170 View commit details
Showing with 4 additions and 2 deletions.
  1. +4 −0 opal/corelib/basic_object.rb
  2. +0 −2 spec/filters/unsupported/basicobject.rb
4 changes: 4 additions & 0 deletions opal/corelib/basic_object.rb
Original file line number Diff line number Diff line change
@@ -34,6 +34,10 @@ def !
false
end

def !=(other)
self != other
end

alias eql? ==
alias equal? ==

2 changes: 0 additions & 2 deletions spec/filters/unsupported/basicobject.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
opal_filter "BasicObject" do
fails "BasicObject#! is a public instance method"
fails "BasicObject#!= is a public instance method"
fails "BasicObject#initialize is a private instance method"
fails "BasicObject#method_missing is a private method"
fails "BasicObject#singleton_method_added is a private method"