[Truffle] Satisfy FindBugs.

jruby · Jun 26, 2015 · beb71c9 · beb71c9
1 parent fed361b
commit beb71c9
Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/tool/truffle-findbugs-exclude.xml b/tool/truffle-findbugs-exclude.xml
@@ -29,6 +29,10 @@
     <Class name="org.jruby.truffle.nodes.exceptions.TopLevelRaiseHandler" />
     <Bug pattern="DM_EXIT" />
   </Match>
+  <Match>
+    <Class name="org.jruby.truffle.nodes.core.CoreMethodNodeManager$AmbiguousOptionalArgumentChecker" />
+    <Bug pattern="DM_EXIT" />
+  </Match>
 
   <!-- Sometimes we really do want to run GC -->
 

diff --git a/truffle/src/main/java/org/jruby/truffle/nodes/core/CoreMethodNodeManager.java b/truffle/src/main/java/org/jruby/truffle/nodes/core/CoreMethodNodeManager.java
@@ -316,7 +316,7 @@ private static void verifyNoAmbiguousOptionalArgumentsWithReflection(MethodDetai
 
                 for (int i = 1; i <= opt; i++) {
                     boolean unguardedObjectArgument = false;
-                    String errors = "";
+                    StringBuilder errors = new StringBuilder();
                     for (Method method : node.getDeclaredMethods()) {
                         if (method.isAnnotationPresent(Specialization.class)) {
                             // count from the end to ignore optional VirtualFrame in front.
@@ -337,7 +337,7 @@ private static void verifyNoAmbiguousOptionalArgumentsWithReflection(MethodDetai
                                 String[] guards = method.getAnnotation(Specialization.class).guards();
                                 if (!isGuarded(name, guards)) {
                                     unguardedObjectArgument = true;
-                                    errors += "\"" + name + "\" in " + methodToString(method, parameterTypes, parameters) + "\n";
+                                    errors.append("\"").append(name).append("\" in ").append(methodToString(method, parameterTypes, parameters)).append("\n");
                                 }
                             }
                         }