Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMMUTANT-568: no concurrent exec job fix #13

Merged
merged 2 commits into from Jun 26, 2015
Merged

IMMUTANT-568: no concurrent exec job fix #13

merged 2 commits into from Jun 26, 2015

Conversation

instilled
Copy link

tobias
tobias reviewed Jun 25, 2015
View reviewed changes
modules/scheduling/src/main/java/org/projectodd/wunderboss/scheduling/Scheduling.java
@@ -35,6 +35,7 @@
public static final ScheduleOption LIMIT = opt("limit", ScheduleOption.class);
public static final ScheduleOption UNTIL = opt("until", ScheduleOption.class);
public static final ScheduleOption SINGLETON = opt("singleton", true, ScheduleOption.class);
public static final ScheduleOption ALLOW_CONCURRENT_EXEC = opt("allow-concurrent-exec?", true, ScheduleOption.class);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option name needs to be "allow_concurrent_exec" so we can use the option from TorqueBox. Immutant will automatically convert :allow-concurrent-exec? to "allow_concurrent_exec".

@tobias
Copy link
Member

tobias commented Jun 25, 2015

Thanks! Looks good. If you can change that option name, I'll merge.

@instilled
Copy link
Author

done!

tobias added a commit that referenced this pull request Jun 26, 2015
@tobias
Merge pull request #13 from instilled/issue-IMMUTANT-568
b94f6e0 
IMMUTANT-568: no concurrent exec job fix
@tobias tobias merged commit b94f6e0 into projectodd:master Jun 26, 2015
@tobias
Copy link
Member

tobias commented Jun 26, 2015

Thanks! I'll merge the Immutant PR as well, and add a test there.

@instilled
Copy link
Author

Thanks Toby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@instilled @tobias