FCREPO-1599 #820
Closed
FCREPO-1599 #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @Override | ||
| public boolean apply(final Event event) { | ||
| public boolean test(final Event event) { |
There was a problem hiding this comment.
Is this class actually used anywhere? Can it be entirely removed?
There was a problem hiding this comment.
I don't think it is, I think it was left as an example. I have no brief for it. @awoods ?
There was a problem hiding this comment.
This class has served its purpose... and deserves to be laid to rest. Drop the monkey on it.
There was a problem hiding this comment.
@ajs6f feel free to remove this class in this PR; otherwise, removing it can be part of a separate PR.
There was a problem hiding this comment.
I'll add a commit with the excision. Monkeys? That's all Fedora needs. Monkeys in the codebase.
|
Made changes: kill NOOPFilter and AllNodeEventsOneEvent Javadoc fix. |
|
Resolved with: aa8748b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor use of Java 8 syntax and types in kernel observation code.