-
-
Notifications
You must be signed in to change notification settings - Fork 925
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 01a3f6851ba6
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: debee1d64d9b
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 2 commits
- 4 files changed
- 1 contributor
Commits on Jun 30, 2015
-
Revert "Fixes #3056. java.lang.IncompatibleClassChangeError in 9.0.0.…
Configuration menu - View commit details
-
Copy full SHA for 11bbc8a - Browse repository at this point
Copy the full SHA 11bbc8aView commit details -
Fixes #3056. java.lang.IncompatibleClassChangeError in 9.0.0.0 rc1.
This replaces the previous fix. The previous fix was wrong because the code in question contained a closure and we were not marking the parent method as scope as BINDING_HAS_ESCAPED. As a result, OptimizeDelegationPass was executing and mucking things up. The previous fix corrected the pass to work with nested closures but it would create new problems if that closure did something which needed to conume the parents binding. The new fix is just a simple oversight in a few of our instructions. ZSuper, UnresolvesSuper, and Match are calls but they were not calling their superclasses computeScopeFlags. This is turn made the issue at hand not notice that the method contained a closure so it never marked BINDING_HAS_ESCAPED. This fix should potentially fix other weird errors where we did not set common call IRScope flags.
Configuration menu - View commit details
-
Copy full SHA for debee1d - Browse repository at this point
Copy the full SHA debee1dView commit details
There are no files selected for viewing