[Truffle] Add missing wasProvided() guards for optional arguments.

* unused arguments are marked as such to allow detecting them in an simple automated way.
jruby · Jun 26, 2015 · 6bbfc01 · 6bbfc01
1 parent bf2df8e
commit 6bbfc01
Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/truffle/src/main/java/org/jruby/truffle/nodes/core/EncodingConverterNodes.java b/truffle/src/main/java/org/jruby/truffle/nodes/core/EncodingConverterNodes.java
@@ -44,7 +44,7 @@ public InitializeNode(RubyContext context, SourceSection sourceSection) {
 
         @TruffleBoundary
         @Specialization
-        public RubyBasicObject initialize(RubyEncodingConverter self, Object source, Object destination, Object options) {
+        public RubyBasicObject initialize(RubyEncodingConverter self, Object source, Object destination, Object unusedOptions) {
             // Adapted from RubyConverter - see attribution there
 
             Ruby runtime = getContext().getRuntime();

diff --git a/truffle/src/main/java/org/jruby/truffle/nodes/core/KernelNodes.java b/truffle/src/main/java/org/jruby/truffle/nodes/core/KernelNodes.java
@@ -1498,12 +1498,12 @@ public RespondToMissingNode(RubyContext context, SourceSection sourceSection) {
         }
 
         @Specialization(guards = "isRubyString(name)")
-        public boolean doesRespondToMissingString(Object object, RubyBasicObject name, Object includeAll) {
+        public boolean doesRespondToMissingString(Object object, RubyBasicObject name, Object unusedIncludeAll) {
             return false;
         }
 
         @Specialization(guards = "isRubySymbol(name)")
-        public boolean doesRespondToMissingSymbol(Object object, RubyBasicObject name, Object includeAll) {
+        public boolean doesRespondToMissingSymbol(Object object, RubyBasicObject name, Object unusedIncludeAll) {
             return false;
         }
 

diff --git a/truffle/src/main/java/org/jruby/truffle/nodes/core/array/ArrayNodes.java b/truffle/src/main/java/org/jruby/truffle/nodes/core/array/ArrayNodes.java
@@ -1934,7 +1934,7 @@ public RubyBasicObject initializeNegative(RubyArray array, int size, Object defa
             throw new RaiseException(getContext().getCoreLibrary().argumentError("negative array size", this));
         }
 
-        @Specialization(guards = { "!isInteger(sizeObject)", "wasProvided(defaultValue)" })
+        @Specialization(guards = { "wasProvided(sizeObject)", "!isInteger(sizeObject)", "wasProvided(defaultValue)" })
         public RubyBasicObject initialize(VirtualFrame frame, RubyArray array, Object sizeObject, Object defaultValue, NotProvided block) {
             if (toIntNode == null) {
                 CompilerDirectives.transferToInterpreter();

diff --git a/truffle/src/main/java/org/jruby/truffle/nodes/ext/BigDecimalNodes.java b/truffle/src/main/java/org/jruby/truffle/nodes/ext/BigDecimalNodes.java
@@ -1203,7 +1203,7 @@ private int getDigits(BigDecimal value) {
         }
 
         @Specialization(guards = "!isNormal(a)")
-        public Object power(VirtualFrame frame, RubyBasicObject a, int exponent, Object precision) {
+        public Object power(VirtualFrame frame, RubyBasicObject a, int exponent, Object unusedPrecision) {
             switch (getBigDecimalType(a)) {
                 case NAN:
                     return createBigDecimal(frame, Type.NAN);
@@ -1625,7 +1625,7 @@ public RubyBasicObject round(VirtualFrame frame, RubyBasicObject value, int digi
         }
 
         @Specialization(guards = "!isNormal(value)")
-        public RubyBasicObject roundSpecial(VirtualFrame frame, RubyBasicObject value, Object precision, Object roundingMode) {
+        public RubyBasicObject roundSpecial(VirtualFrame frame, RubyBasicObject value, Object unusedPrecision, Object unusedRoundingMode) {
             switch (getBigDecimalType(value)) {
                 case NEGATIVE_INFINITY:
                     CompilerDirectives.transferToInterpreter();