Fixing little things in WordPress importer (WIP) #1847
Conversation
|
Parts will be fixed in #1824. Missing at the moment: exception raised by |
|
The currently failed checks are due to a disk full error on Travis, and a missing import |
| tag = utils.slugify(tag.decode('utf8')) | ||
| # In python 2, path is a str. slug requires a unicode | ||
| # object. According to wikipedia, unquoted strings will | ||
| # usually be UTF8 |
There was a problem hiding this comment.
Link to that wikipedia page in code comments.
There was a problem hiding this comment.
This piece is essentially a copy'n'paste from somewhere else in the same source file. The original comment has no link to Wikipedia, either.
|
Please make this mergeable and use try/except for decoding, and you can merge as soon as Travis builds. |
|
Should I modify both occurences in this case? (The second is here: https://github.com/getnikola/nikola/blob/master/nikola/plugins/command/import_wordpress.py#L419) |
felixfontein
force-pushed
the
fix-wordpress-import
branch
from
063afb9
to
c926116
Compare
|
Ok, modified both. Now merging. |
Fixing little things in WordPress importer (WIP)
When importing a WordPress blog whose blog description was not set, I got
nullinserted intoconf.pyinstead of"PUT DESCRIPTION HERE", which causednikola buildto fail. This is fixed in 5781644.Then, there are two more problems with the WordPress importer which make it fail for me; see comments here: b6cbfcbc