-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9K seems to be handling all jruby.xxx properties #3288
Comments
@kares perhaps we will just special case anything starting with jruby.openssl. ? |
how about letting unknown ones through, is that not possible? |
Here's the first weird thing - why is the warning being printed twice? It turns out that JRuby runs
Is that the right behaviour? |
As for actually fixing this issue, I can do two things - we can remove this feature that warns you about an unknown property (and that's all it is by the way - a warning - we don't 'handle' it as in removing it or something like that). But that does seem a shame as I think it's useful. Or we could add a feature that says ignore properties in |
aah, right - there's actually no debug lines to be printed in my script :) ... my bad thought this is more serious. at this point I do not care what the fix is - if its a useful feature for users than keep it and add jruby.openssl.* as a know pattern. maybe jruby-openssl is the only one using the jruby.xxx namespace. |
@chrisseaton I think we keep going and just add jruby.openssl.* to the exclude list. We could eventually go whole hog and let libraries register these properties but that seems a bit over the top. Let's try something simple as a workaround. |
@chrisseaton thanks ... and maybe we need another bug for the |
oh you already did it, just noticed |
they're used e.g. with gems such as jruby-openssl the jruby.openssl.xxx namespace is used :
... no longer works as it used to on JRuby 1.7
The text was updated successfully, but these errors were encountered: