Support negotiating up to TLS1_1 and TLS1_2 when the server supports these ssl_versions #63
+40
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…these ssl_versions
|
Looks like TLS1_1 and TLS1_2 are not supported by jdk6 so I added conditional logic around the tests and SSL constant to only run in java 7+ |
|
picked on master (with some updated test-excludes), thanks! |
|
Thanks for fixing the tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue we were having where JRuby apps couldn't connect to a server running only with TLS1_1 and TLS1_2 enabled unless you specifically told the JRuby client to use TLS1_1 or TLS1_2. The JRuby client would not negotiate up to the highest ssl version allowed by the server, it would always stop at TLS1.