New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tear fcrepo-transform out #887
Conversation
I assume we will want to make sure the vagrant machinery (fcrepo-webapp-plus) is still including fcrepo-transform so Solr indexing will still work. |
Ok. Since I can't create a repo under fcrepo4-exts. I made the fcrepo-transform under my user. Which you can fork or whatever. Is that what you are referring to or did I miss the point? |
Here you go: https://github.com/fcrepo4-exts/fcrepo-transform |
You'll want to be sure the version history persists. |
@acoburn, indeed. It looks like the git history got lost during the extraction from the core codebase. |
Still don't think I can push to that repository, but I have fixed mine to maintain the version history. |
@whikloj you should be able to issue a PR to that repo |
@acoburn I think I would have to clone your empty repo and then fill it again. I think it would be easier if you forked my fcrepo-transform repo into fcrepo-exts. |
@acoburn - or more precisely.
|
The following files also need to be removed (and the entire fcrepo-transform directory):
Also, we do not want any dependencies in fcrepo4 on projects in fcrepo4-exts. Therefore, you also need to remove |
Also, will fcrepo-transform remain in the org.fcrepo maven group? Or will it change to org.fcrepo.transform? |
@acoburn, yes, moving to the |
so does the parent become the org.sonatype.oss like fcrepo-camel and fcrepo4? |
@whikloj I'd keep the parent as it is for now. |
@whikloj just an FYI, there is a ticket for creating an But I have to address some code review comments before we can finalize that ticket. |
@whikloj can you rebase this PR with the latest updates from master? |
@acoburn rebased |
Resolved with: 266bc0a |
Addresses FCREPO-1670