Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tear fcrepo-transform out #887

Closed
wants to merge 3 commits into from
Closed

Conversation

whikloj
Copy link
Collaborator

@whikloj whikloj commented Aug 18, 2015

@awoods
Copy link

awoods commented Aug 18, 2015

I assume we will want to make sure the vagrant machinery (fcrepo-webapp-plus) is still including fcrepo-transform so Solr indexing will still work.
That implies moving fcrepo-transform into fcrepo4-exts.

@whikloj
Copy link
Collaborator Author

whikloj commented Aug 18, 2015

Ok. Since I can't create a repo under fcrepo4-exts. I made the fcrepo-transform under my user.

Which you can fork or whatever. Is that what you are referring to or did I miss the point?

@acoburn
Copy link
Contributor

acoburn commented Aug 18, 2015

@acoburn
Copy link
Contributor

acoburn commented Aug 18, 2015

You'll want to be sure the version history persists.

@awoods
Copy link

awoods commented Aug 18, 2015

@acoburn, indeed. It looks like the git history got lost during the extraction from the core codebase.

@acoburn
Copy link
Contributor

acoburn commented Aug 18, 2015

@whikloj
Copy link
Collaborator Author

whikloj commented Aug 18, 2015

Still don't think I can push to that repository, but I have fixed mine to maintain the version history.

@acoburn
Copy link
Contributor

acoburn commented Aug 18, 2015

@whikloj you should be able to issue a PR to that repo

@whikloj
Copy link
Collaborator Author

whikloj commented Aug 18, 2015

@acoburn I think I would have to clone your empty repo and then fill it again. I think it would be easier if you forked my fcrepo-transform repo into fcrepo-exts.

@whikloj
Copy link
Collaborator Author

whikloj commented Aug 18, 2015

@acoburn - or more precisely.

git clone https://github.com/fcrepo4/fcrepo4 fcrepo4-transform
git remote rm origin
git filter-branch --subdirectory-filter fcrepo-transform -- --all
git add remote origin https://github.com/fcrepo4-exts/fcrepo-transform
git branch --set-upstream-to=origin

@acoburn
Copy link
Contributor

acoburn commented Aug 19, 2015

Also, will fcrepo-transform remain in the org.fcrepo maven group? Or will it change to org.fcrepo.transform?

@awoods
Copy link

awoods commented Aug 19, 2015

@acoburn, yes, moving to the org.fcrepo.transform group makes sense.

@whikloj
Copy link
Collaborator Author

whikloj commented Aug 19, 2015

so does the parent become the org.sonatype.oss like fcrepo-camel and fcrepo4?

@acoburn
Copy link
Contributor

acoburn commented Aug 19, 2015

@whikloj I'd keep the parent as it is for now.

@acoburn
Copy link
Contributor

acoburn commented Aug 19, 2015

@whikloj just an FYI, there is a ticket for creating an fcrepo-parent POM so that extension modules can inherit from that rather than from org.sonatype.oss (as is currently the case with fcrepo-camel and fcrepo-camel-toolbox): https://jira.duraspace.org/browse/FCREPO-1684

But I have to address some code review comments before we can finalize that ticket.

@acoburn
Copy link
Contributor

acoburn commented Oct 14, 2015

@whikloj can you rebase this PR with the latest updates from master?

@whikloj
Copy link
Collaborator Author

whikloj commented Oct 14, 2015

@acoburn rebased

@awoods
Copy link

awoods commented Oct 19, 2015

Resolved with: 266bc0a

@awoods awoods closed this Oct 19, 2015
@awoods awoods deleted the FCREPO-1670 branch October 19, 2015 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants