[Truffle] Allow for lazy parsing #3290
Merged
+44
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it lazy parsing or lazy translation? I would guess the latter, right? |
|
It does parsing and translation of method bodies lazily. During image generation we parse all ruby files, identify the method boundaries, and delete the method bodies. So a method like: Becomes: The actual code of the method body is stored in another data structure. When a file is parsed, if I have entries for the methods in that file, I insert a node that does lazy parsing as the method's body. This node gets the original code for the method, parses and translates it, and replaces itself with the result. |
|
Nice, merging! |
eregon
added a commit
that referenced
this pull request
Aug 28, 2015
[Truffle] Allow for lazy parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make it possible to lazily parse methods in ahead of time compiled images. During image generation method bodies are elided from the core source files and stored in a separate data structure. When the file is initially parsed, the method body is replaced with a node to perform the lazy parsing. When this node is executed, it performs the parsing and then replaces itself with the code of the method.