slurp a little faster

mojolicious · Aug 18, 2015 · 683f4a2 · 683f4a2
1 parent ec6fc90
commit 683f4a2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/Changes b/Changes
@@ -1,7 +1,8 @@
 
-6.16  2015-08-16
+6.16  2015-08-18
   - Improved check_box, radio_button and select_field tag helpers to handle the
     attributes "checked" and "selected" correctly.
+  - Improved performance of slurp function in Mojo::Util slightly.
 
 6.15  2015-08-13
   - Removed deprecated build_body and build_headers methods from Mojo::Content.

diff --git a/lib/Mojo/Util.pm b/lib/Mojo/Util.pm
@@ -233,9 +233,9 @@ sub sha1_sum   { sha1_hex @_ }
 
 sub slurp {
   my $path = shift;
-  croak qq{Can't open file "$path": $!} unless open my $file, '<', $path;
+  croak qq{Can't open file "$path": $!} unless open my $file, '<:unix', $path;
   my $content = '';
-  while ($file->sysread(my $buffer, 131072, 0)) { $content .= $buffer }
+  while (read $file, my $buffer, 131072, 0) { $content .= $buffer }
   return $content;
 }