You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Could you please temporarily enable Travis on longlong-double-fix branche. It passes all tests for me but I am not able to test it on all PDL environments that you have configured on Travis.
The text was updated successfully, but these errors were encountered:
Could you please make a new branch eg lldf-kmx and work on that? Also, if you were going to copy the existing branch and make further changes, you need to not use merge commits but instead rebase.
If you have done that, then you can pull-request (aka PR) your new branch, and it will then get CI-ed.
Ad rebase: I know that it is preferred to rebase instead of merge but this branch (longlong-double-fix) has at least Chris on his computer. I am not very advanced git user but rebase would mean to git push --force that means rewriting branch history which is perhaps not a good idea providing that the branch is not only mine, or not? Anyway longlong-double-fix branche is still kind of experimenting/testing area and IMO all the changes should be in the end squashed into one commit before going to master, therefore I do not see merging master to longlong-double-fix (= polluting longlong-double-fix commit history) as a big issue.
Ad PR: I have now PDL repo cloned from sf.net What's the easiest way to create github PR? Should I create a separate git fork/clone from github?
Could you please temporarily enable Travis on longlong-double-fix branche. It passes all tests for me but I am not able to test it on all PDL environments that you have configured on Travis.
The text was updated successfully, but these errors were encountered: