Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Refactor some of the require system #3269

Merged
merged 17 commits into from
Aug 22, 2015
Merged

Conversation

chrisseaton
Copy link
Contributor

  • Fixes the problem we had loading stdlib from a jar.
  • Allows you to modify where core is loaded from with -Xtruffle.core.load_path=truffle/src/main/ruby for better stack traces
  • Some general tidy up

@chrisseaton chrisseaton self-assigned this Aug 20, 2015
@chrisseaton chrisseaton added this to the truffle-dev milestone Aug 20, 2015
@@ -0,0 +1 @@
fails:Thread::Backtrace::Location#to_s converts the call frame to a String
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have fixed these.

@pitr-ch
Copy link
Member

pitr-ch commented Aug 20, 2015

Nice. Would it make sense to have Xtruffle.core.load_path=truffle/src/main/ruby as default in jt?

@chrisseaton
Copy link
Contributor Author

Yes - I don't think that could ever mean you were testing in an inconsistent state so that should be fine - I'll add that.

chrisseaton added a commit that referenced this pull request Aug 22, 2015
[Truffle] Refactor some of the require system
@chrisseaton chrisseaton merged commit cbc7c76 into master Aug 22, 2015
@chrisseaton chrisseaton deleted the truffle-new-require branch January 18, 2016 13:14
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants