improve slurp method in Mojo::Asset::File to only use one file descri…

…ptor
mojolicious · Aug 21, 2015 · ec7920e · ec7920e
1 parent 6d1e9cf
commit ec7920e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/Changes b/Changes
@@ -1,5 +1,6 @@
 
-6.17  2015-08-20
+6.17  2015-08-21
+  - Improved slurp method in Mojo::Asset::File to only use one file descriptor.
 
 6.16  2015-08-19
   - Improved check_box, radio_button and select_field tag helpers to handle the

diff --git a/lib/Mojo/Asset/File.pm b/lib/Mojo/Asset/File.pm
@@ -124,8 +124,11 @@ sub mtime { (stat shift->handle)[9] }
 sub size { -s shift->handle }
 
 sub slurp {
-  return '' unless defined(my $file = shift->path);
-  return Mojo::Util::slurp $file;
+  my $handle = shift->handle;
+  $handle->sysseek(0, SEEK_SET);
+  defined $handle->sysread(my $content, -s $handle, 0)
+    or croak qq{Can't read from asset: $!};
+  return $content;
 }
 
 1;