return the same ssl_version format that is presented in OpenSSL::SSL::SSLContext::METHODS and also matches MRI #66
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:SSLContext::METHODS and also matches MRI
|
the test changes are NOT compatible with MRI ... e.g. on 2.2.2 I'm getting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the comment for the OpenSSL::SSL::SSLContext::METHODS implementation we don't want to expose TLSv1.1 or TLSv1.2 as ssl_version options. This change should keep those strings from coming out via the ssl_version accessor.
NOTE: This change is backwards incompatible if anyone is currently checking the ssl_version against TLSv1.1 or TLSv1.2.