Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis-CI for longlong-double-fix branche (temporarily) #141

Closed
kmx opened this issue Aug 26, 2015 · 3 comments
Closed

Travis-CI for longlong-double-fix branche (temporarily) #141

kmx opened this issue Aug 26, 2015 · 3 comments

Comments

@kmx
Copy link
Contributor

kmx commented Aug 26, 2015

Could you please temporarily enable Travis on longlong-double-fix branche. It passes all tests for me but I am not able to test it on all PDL environments that you have configured on Travis.

@mohawk2
Copy link
Member

mohawk2 commented Aug 26, 2015

Could you please make a new branch eg lldf-kmx and work on that? Also, if you were going to copy the existing branch and make further changes, you need to not use merge commits but instead rebase.

If you have done that, then you can pull-request (aka PR) your new branch, and it will then get CI-ed.

@kmx
Copy link
Contributor Author

kmx commented Aug 26, 2015

Ad rebase: I know that it is preferred to rebase instead of merge but this branch (longlong-double-fix) has at least Chris on his computer. I am not very advanced git user but rebase would mean to git push --force that means rewriting branch history which is perhaps not a good idea providing that the branch is not only mine, or not? Anyway longlong-double-fix branche is still kind of experimenting/testing area and IMO all the changes should be in the end squashed into one commit before going to master, therefore I do not see merging master to longlong-double-fix (= polluting longlong-double-fix commit history) as a big issue.

Ad PR: I have now PDL repo cloned from sf.net What's the easiest way to create github PR? Should I create a separate git fork/clone from github?

@kmx
Copy link
Contributor Author

kmx commented Aug 26, 2015

The trick with github pull request did it, closing. Thanks.

@kmx kmx closed this as completed Aug 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants