Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAWKULAR-565 Bring/expose the new Inventory REST APIs into the ui-services #28

Merged
merged 2 commits into from Sep 3, 2015

Conversation

jkremser
Copy link
Member

This PR exposes the functionality that is new in Inventory 0.3.0

NOTE: this requires the ui code to change, because some of the resources were renamed

@mtho11
Copy link
Member

mtho11 commented Aug 19, 2015

So this should have a do not merge tag on it?

@mtho11
Copy link
Member

mtho11 commented Aug 19, 2015

@Jiri-Kremser do you plan on making those changes needed?

@jkremser
Copy link
Member Author

So this should have a do not merge tag on it?

right, well, it's always kind of chicken-egg problem here, what should go first? The backend change, the ui-services that depends on this backend api? or the hawkular/hawkular ui code that uses the ui-services, but at the same time increases the version of the component with the backend change.

Obviously the backend change can go first, because it doesn't depend on the UI (nor ui-services), but it's not so clear with the hawkular/hawkular and hawkular/ui-services, in ideal world the 2 PRs should be merged in the same moment. Or firstly, release the new version of the ui-services and let the hawkular ui still depend on the latest-1 version.

so it can be merged provided the hawkular ui will not depend on it immediately

do you plan on making those changes needed?

yes, I can do that (tomorrow perhaps)

@vrockai could you please review?

@vrockai
Copy link
Contributor

vrockai commented Aug 19, 2015

@Jiri-Kremser , I just went through the code and it seems fine. Just two tiny remarks:

  • Please don't add dist files to the commit. The dist is generated before release and it's part of the release commit.
  • Could you please add rest-tests for new entities?

@jkremser
Copy link
Member Author

Please don't add dist files to the commit. The dist is generated before release and it's part of the release commit.

  • checked

Could you please add rest-tests for new entities?

  • checked

@jkremser
Copy link
Member Author

jkremser commented Sep 3, 2015

rebased against latest master and ready to merge (this PR should go right after this one hawkular/hawkular-dist-old#434)

mtho11 added a commit that referenced this pull request Sep 3, 2015
HAWKULAR-565 Bring/expose the new Inventory REST APIs into the ui-services
@mtho11 mtho11 merged commit c9bd667 into hawkular:master Sep 3, 2015
@mtho11
Copy link
Member

mtho11 commented Sep 3, 2015

Merged #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants