-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HAWKULAR-565 Bring/expose the new Inventory REST APIs into the ui-services #28
Conversation
So this should have a do not merge tag on it? |
@Jiri-Kremser do you plan on making those changes needed? |
right, well, it's always kind of chicken-egg problem here, what should go first? The backend change, the ui-services that depends on this backend api? or the hawkular/hawkular ui code that uses the ui-services, but at the same time increases the version of the component with the backend change. Obviously the backend change can go first, because it doesn't depend on the UI (nor ui-services), but it's not so clear with the so it can be merged provided the hawkular ui will not depend on it immediately
yes, I can do that (tomorrow perhaps) @vrockai could you please review? |
@Jiri-Kremser , I just went through the code and it seems fine. Just two tiny remarks:
|
|
…vices + little refactoring (renaming)
b3e9874
to
871b894
Compare
rebased against latest master and ready to merge (this PR should go right after this one hawkular/hawkular-dist-old#434) |
HAWKULAR-565 Bring/expose the new Inventory REST APIs into the ui-services
Merged #28 |
This PR exposes the functionality that is new in Inventory
0.3.0
NOTE: this requires the ui code to change, because some of the resources were renamed