fix(ngTouch): don't blur form elements #11212
Conversation
|
Might this be included in the 1.4.1 milestone rather than the amorphous 1.4.x milestone? Pretty please? |
|
@mikec looks like there are some merge conflicts - would you able to rebase? |
Form element focus should not be prevented by ng-click. The issue was introduced by angular#2989, and happens on mobile browsers that support touch events. Plunker to demonstrate the issue: http://embed.plnkr.co/CxeuWocoPE70vzrevrIi Closes angular#4030, angular#6432
mikec
force-pushed
the
fix-form-element-focus
branch
from
65e21c2
to
c235450
Compare
|
@ChristianV: rebased |
|
@petebacondarwin would you mind doing a review? Currently we have to load a modified version of the directive with every release until it's fixed. |
|
The bug was with NgTouch in my case. |
|
@ChristianV - I don't think we can land this PR as it is since you are basically removing something, that even has a test, and was fixing another bug. This means that this PR would cause that bug to reappear. Instead how about we consider the more drastic action of removing ngClick from ngTouch altogether? |
|
@petebacondarwin created a follow up at #12317 - would you be able to take a look? |
|
Closing in favour of #12317 |
Form element focus should not be prevented by ng-click.
The issue was introduced by #2989, and happens on mobile browsers that support touch events.
Plunker to demonstrate the issue: http://embed.plnkr.co/CxeuWocoPE70vzrevrIi
Closes #4030, #6432