FCREPO-1505 (https://jira.duraspace.org/browse/FCREPO-1505) #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handling the creation of child objects for pairtree child resources; Implementing the FedoraLdpIT#testIngestOnPairTree method for integration testing
| @@ -415,6 +421,9 @@ public Response createObject(@QueryParam("checksum") final String checksum, | |||
|
|
|||
| if (!(resource() instanceof Container)) { | |||
| throw new ClientErrorException("Object cannot have child nodes", CONFLICT); | |||
| } else if (resource().hasType(FEDORA_PAIRTREE)) { | |||
|
|
|||
| throw new ClientErrorException("Object cannot themselves be children of a pairtree child node", FORBIDDEN); | |||
There was a problem hiding this comment.
Can we fix the grammar of this message?
…n FedoraLdp#createObject; Restructuring the test case for FedoraLdpIT#testIngestOnPairtree (following the approach used in FedoraExportIT#shouldRoundTripOnePairtree)
| createLiteral(FEDORA_PAIRTREE))); | ||
|
|
||
| // Attempting to POST to the child of the pairtree node... | ||
| method = new HttpPost(serverAddress + pairtreeName); |
There was a problem hiding this comment.
Use AbstractResourceIT::postObjMethod.
…e AbstractResourceIT::getObjMethod, AbstractResourceIT::postObjMethod, and AbstractResourceIT::getStatus where appropriate; Modifying the 403 response message within FedoraLdp#createObject and FedoraLdpIT#testIngestOnPairtree
… is declared as "final" within FedoraLdpIT#testIngestOnPairtree
|
Resolved with: 15373cb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending the FedoraLdp#createObject method for handling the creation of child objects for pairtree child resources; Implementing the FedoraLdpIT#testIngestOnPairTree method for integration testing.