Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error out swarm filter when no daemon is online #1464

Merged
merged 1 commit into from
Jul 11, 2015
Merged

Conversation

whyrusleeping
Copy link
Member

makes ipfs swarm filters not panic when run offline.

License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com

License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
@whyrusleeping whyrusleeping added the status/in-progress In progress label Jul 10, 2015
if n.PeerHost == nil {
res.SetError(errNotOnline, cmds.ErrNormal)
return
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably need it in rm too, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its there already

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhhh that's what happened

jbenet added a commit that referenced this pull request Jul 11, 2015
error out swarm filter when no daemon is online
@jbenet jbenet merged commit 7077d71 into master Jul 11, 2015
@jbenet jbenet removed the status/in-progress In progress label Jul 11, 2015
@jbenet jbenet deleted the fix/filters-offline branch July 11, 2015 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants