Precompiled .class can't reflect new filename #3109
Labels
Milestone
Comments
headius
added a commit
that referenced
this issue
Jul 6, 2015
Note that there's still one missing piece, as detailed in #3109: we are not updating loaded scripts with their actual filename. The original filename they were compiled from is still there, which may cause problems with require_relative and friends.
headius
added a commit
that referenced
this issue
Jul 6, 2015
Fixes #3109 Because compiled scripts may be moved around or loaded from locations different than when they were compiled, we must pass filename into the decoding process to allow the script to reflect the new filename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the old precompiler, the Script loaded from a .class was immediately updated to reflect its actual FILE location. The new precompiler just serializes the IR, which embeds the original filename as a literal string.
We need to modify serialization and loading of IR to replace the old filename with the new, actual filename.
The text was updated successfully, but these errors were encountered: