jruby · Jul 3, 2015 · Jul 3, 2015 · Jul 3, 2015 · Jul 3, 2015 · Jul 3, 2015
diff --git a/lib/ruby/truffle/truffle/bigdecimal.rb b/lib/ruby/truffle/truffle/bigdecimal.rb
@@ -39,15 +39,16 @@ def self.mode(key, value = nil)
     else
       Thread.current[:'BigDecimal.exception_mode'] ||= 0
       case value
-        when true
-          Thread.current[:'BigDecimal.exception_mode'] |= key
-          return value
-        when false
-          Thread.current[:'BigDecimal.exception_mode'] &= ~key
-          return value
-        when nil
-          # FIXME (pitr 20-Jun-2015): CRuby always returns BigDecimal.exception_mode internal value ignoring the key
-          return Thread.current[:'BigDecimal.exception_mode'] & key == key
+      when true
+        Thread.current[:'BigDecimal.exception_mode'] |= key
+        return value
+      when false
+        Thread.current[:'BigDecimal.exception_mode'] &= ~key
+        return value
+      when nil
+        return Thread.current[:'BigDecimal.exception_mode']
+      else
+        raise ArgumentError, 'second argument must be true or false'
       end
     end
   end
@@ -69,6 +70,14 @@ def self.name
     'BigDecimal'
   end
 
+  def self.double_fig
+    20
+  end
+
+  def self.ver
+    '1.1.0'
+  end
+
   def ==(o)
     (self <=> o) == 0 rescue false
   end
@@ -181,6 +190,98 @@ def frac
       self
     end
   end
+
+  def to_s(format = 'E')
+    if finite?
+      float_format    = format[-1] == 'F'
+      space_frequency = format.to_i
+      prefix          = if self > 0 && [' ', '+'].include?(format[0])
+                          format[0]
+                        elsif self < 0
+                          '-'
+                        else
+                          ''
+                        end
+      unscaled_value  = unscaled
+      exponent_value  = exponent
+
+      if float_format
+        case
+        when exponent_value > unscaled_value.size
+          before_dot = unscaled_value + '0' * (exponent_value - unscaled_value.size)
+          after_dot  = '0'
+        when exponent_value <= 0
+          before_dot = '0'
+          after_dot  = '0' * exponent_value.abs + unscaled_value
+        else
+          before_dot = unscaled_value[0...exponent_value]
+          rest       = unscaled_value[exponent_value..-1]
+          after_dot  = rest.empty? ? '0' : rest
+        end
+
+        format '%s%s.%s',
+               prefix,
+               add_spaces_to_s(before_dot, true, space_frequency),
+               add_spaces_to_s(after_dot, false, space_frequency)
+      else
+        format '%s0.%sE%d',
+               prefix,
+               add_spaces_to_s(unscaled_value, false, space_frequency),
+               exponent_value
+      end
+    else
+      (sign < 0 ? '-' : '') + unscaled
+    end
+  end
+
+  def inspect
+    precs1, precs2 = precs
+
+    format "#<BigDecimal:%s,'%s',%d(%d)>",
+           object_id.to_s(16),
+           to_s,
+           precs1,
+           precs2
+  end
+
+  def _dump(level)
+    # TODO (pitr 30-jun-2015): increase density
+    to_s
+  end
+
+  def self._load(data)
+    new data
+  end
+
+  private
+
+  def add_spaces_to_s(string, reverse, space_frequency)
+    return string if space_frequency == 0
+
+    remainder = string.size % space_frequency
+    shift     = reverse ? remainder : 0
+    pieces    = (string.size / space_frequency).times.map { |i| string[space_frequency*i + shift, space_frequency] }
+
+    if remainder > 0
+      if reverse
+        pieces.unshift string[0...remainder]
+      else
+        pieces.push string[-remainder..-1]
+      end
+    end
+
+    pieces.join ' '
+  end
+
+  def self.boolean_mode(key, value = nil)
+    if value.nil?
+      mode(key) & key == key
+    else
+      mode key, value
+    end
+  end
+
+  private_class_method :boolean_mode
 end
 
 BigDecimal = Truffle::BigDecimal

diff --git a/spec/ruby/library/bigdecimal/div_spec.rb b/spec/ruby/library/bigdecimal/div_spec.rb
@@ -45,6 +45,7 @@
   it "raises FloatDomainError if NaN is involved" do
     lambda { @one.div(@nan) }.should raise_error(FloatDomainError)
     lambda { @nan.div(@one) }.should raise_error(FloatDomainError)
+    lambda { @nan.div(@nan) }.should raise_error(FloatDomainError)
   end
 
   it "returns 0 if divided by Infinity and no precision given" do
@@ -66,6 +67,7 @@
 
     lambda { @zero.div(@zero) }.should raise_error(ZeroDivisionError)
     lambda { @zero_minus.div(@zero_plus) }.should raise_error(ZeroDivisionError)
+    lambda { @zero_minus.div(@zero_minus) }.should raise_error(ZeroDivisionError)
     lambda { @zero_plus.div(@zero_minus) }.should raise_error(ZeroDivisionError)
   end
 

diff --git a/spec/truffle/tags/library/bigdecimal/div_tags.txt b/spec/truffle/tags/library/bigdecimal/div_tags.txt
diff --git a/spec/truffle/tags/library/bigdecimal/divmod_tags.txt b/spec/truffle/tags/library/bigdecimal/divmod_tags.txt
@@ -1,16 +1,2 @@
-fails:BigDecimal#mod_part_of_divmod returns self modulo other
-fails:BigDecimal#mod_part_of_divmod returns a [Float value] when the argument is Float
-fails:BigDecimal#mod_part_of_divmod returns NaN if NaN is involved
-fails:BigDecimal#mod_part_of_divmod returns NaN if the dividend is Infinity
-fails:BigDecimal#mod_part_of_divmod returns the dividend if the divisor is Infinity
 fails:BigDecimal#mod_part_of_divmod raises TypeError if the argument cannot be coerced to BigDecimal
-fails:BigDecimal#divmod divides value, returns an array
-fails:BigDecimal#divmod array contains quotient and modulus as BigDecimal
-fails:BigDecimal#divmod Can be reversed with * and +
-fails:BigDecimal#divmod returns an array of two NaNs if NaN is involved
-fails:BigDecimal#divmod returns an array of Infinity and NaN if the dividend is Infinity
-fails:BigDecimal#divmod returns an array of zero and the dividend if the divisor is Infinity
-fails:BigDecimal#divmod returns an array of two zero if the diviend is zero
 fails:BigDecimal#divmod raises TypeError if the argument cannot be coerced to BigDecimal
-fails:BigDecimal#mod_part_of_divmod raises ZeroDivisionError if other is zero
-fails:BigDecimal#divmod raises ZeroDivisionError if the divisor is zero
diff --git a/spec/truffle/tags/library/bigdecimal/double_fig_tags.txt b/spec/truffle/tags/library/bigdecimal/double_fig_tags.txt
diff --git a/spec/truffle/tags/library/bigdecimal/inspect_tags.txt b/spec/truffle/tags/library/bigdecimal/inspect_tags.txt
diff --git a/spec/truffle/tags/library/bigdecimal/modulo_tags.txt b/spec/truffle/tags/library/bigdecimal/modulo_tags.txt
@@ -1,14 +1,2 @@
-fails:BigDecimal#% returns self modulo other
-fails:BigDecimal#% returns a [Float value] when the argument is Float
-fails:BigDecimal#% returns NaN if NaN is involved
-fails:BigDecimal#% returns NaN if the dividend is Infinity
-fails:BigDecimal#% returns the dividend if the divisor is Infinity
 fails:BigDecimal#% raises TypeError if the argument cannot be coerced to BigDecimal
-fails:BigDecimal#modulo returns self modulo other
-fails:BigDecimal#modulo returns a [Float value] when the argument is Float
-fails:BigDecimal#modulo returns NaN if NaN is involved
-fails:BigDecimal#modulo returns NaN if the dividend is Infinity
-fails:BigDecimal#modulo returns the dividend if the divisor is Infinity
 fails:BigDecimal#modulo raises TypeError if the argument cannot be coerced to BigDecimal
-fails:BigDecimal#% raises ZeroDivisionError if other is zero
-fails:BigDecimal#modulo raises ZeroDivisionError if other is zero
diff --git a/spec/truffle/tags/library/bigdecimal/remainder_tags.txt b/spec/truffle/tags/library/bigdecimal/remainder_tags.txt
@@ -1,8 +1 @@
-fails:BigDecimal#remainder it equals modulo, if both values are of same sign
-fails:BigDecimal#remainder means self-arg*(self/arg).truncate
-fails:BigDecimal#remainder returns NaN used with zero
-fails:BigDecimal#remainder returns zero if used on zero
-fails:BigDecimal#remainder returns NaN if NaN is involved
-fails:BigDecimal#remainder returns NaN if Infinity is involved
-fails:BigDecimal#remainder coerces arguments to BigDecimal if possible
 fails:BigDecimal#remainder raises TypeError if the argument cannot be coerced to BigDecimal
diff --git a/spec/truffle/tags/library/bigdecimal/sqrt_tags.txt b/spec/truffle/tags/library/bigdecimal/sqrt_tags.txt
@@ -0,0 +1,3 @@
+fails:BigDecimal#sqrt raises TypeError if nil is given
+fails:BigDecimal#sqrt raises TypeError if a string is given
+fails:BigDecimal#sqrt raises TypeError if a plain Object is given
diff --git a/spec/truffle/tags/library/bigdecimal/to_s_tags.txt b/spec/truffle/tags/library/bigdecimal/to_s_tags.txt
diff --git a/spec/truffle/tags/library/bigdecimal/ver_tags.txt b/spec/truffle/tags/library/bigdecimal/ver_tags.txt