Unifying compiler extensions #1864
Conversation
…iding simple accessing functions for compiler extensions for a given page compiler.
…et_compiler_extensions().
|
Broken: https://ci.appveyor.com/project/Kwpolska/nikola/build/1.0.1865#L1681 |
|
Yapsy does find them. There's another problem, and I'm currently working on it. |
…ion and MarkdownExtension class definitions as plugins and ignore the real plugin defined in the same file.
|
We have to activate all three names, but not because yapsy won't identify derived classes of |
|
Part of the problem is I think that many plugins in Nikola ignore the advice here: http://yapsy.sourceforge.net/Advices.html#plugin-class-detection-caveat |
|
We can’t fix it now, there would be so many things to change. |
|
I assume that the failed invariance test is part of another PR. The rest seems to work fine now. |
| @@ -239,5 +242,17 @@ def __init__(self): | |||
| self.template_system = self | |||
| self.name = 'mako' | |||
|
|
|||
| def _activate_plugins_of_category(self, category): | |||
There was a problem hiding this comment.
This is code duplication, is it possible to import nikola.nikola and do FakeSite._activate_plugins_of_category = nikola.nikola.Nikola._activate_plugins_of_category instead?
There was a problem hiding this comment.
Seems to work locally for me, now let's see what Travis and AppVeyor say :)
There was a problem hiding this comment.
Doesn't seem to work. What about moving the method to nikola.utils and calling it explicitly with a site instance?
There was a problem hiding this comment.
Nah, let’s just keep it duplicated. Reverting and merging.
(Invariance failures are caused by this being branched out before rst.css and aria fixes.)
This reverts commit ceda8e9.
|
Thanks! |
In c65be6e Kwpolska added a new plugin class,
CompilerExtension, and madeMarkdownExtensionandRestExtensionsubclasses of this new plugin class. This PR moves the plugin loading code from the Rest and Markdown plugins into a common place inPageCompiler, which can be used by all page compiler plugins.