Skip to content

Commit f1f9d0a

Browse files
committedJul 5, 2015
Fix #1863 -- add aria tags to BS3 navbars
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
1 parent f23353b commit f1f9d0a

File tree

5 files changed

+4
-10
lines changed

5 files changed

+4
-10
lines changed
 

‎nikola/data/themes/bootstrap3-jinja/assets/css/theme.css

-6
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,6 @@ div.figure > a > img {
5151
margin-right: auto;
5252
}
5353

54-
div.sidebar, div.admonition, div.attention, div.caution, div.danger, div.error, div.hint, div.important, div.note, div.tip, div.warning {
55-
/* Issue 277 */
56-
border: 1px solid #aaa;
57-
border-radius: 5px;
58-
}
59-
6054
blockquote p, blockquote {
6155
font-size: 17.5px;
6256
font-weight: 300;

‎nikola/data/themes/bootstrap3-jinja/templates/base.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<nav class="navbar navbar-inverse navbar-static-top" role="navigation">
1717
<div class="container"><!-- This keeps the margins nice -->
1818
<div class="navbar-header">
19-
<button type="button" class="navbar-toggle" data-toggle="collapse" data-target=".navbar-ex1-collapse">
19+
<button type="button" class="navbar-toggle" data-toggle="collapse" data-target=".navbar-ex1-collapse" aria-expanded="false">
2020
<span class="sr-only">Toggle navigation</span>
2121
<span class="icon-bar"></span>
2222
<span class="icon-bar"></span>

‎nikola/data/themes/bootstrap3-jinja/templates/base_helper.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ lang="{{ lang }}">
129129
{% macro html_navigation_links() %}
130130
{% for url, text in navigation_links[lang] %}
131131
{% if isinstance(url, tuple) %}
132-
<li class="dropdown"><a href="#" class="dropdown-toggle" data-toggle="dropdown">{{ text }} <b class="caret"></b></a>
132+
<li class="dropdown"><a href="#" class="dropdown-toggle" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">{{ text }} <b class="caret"></b></a>
133133
<ul class="dropdown-menu">
134134
{% for suburl, text in url %}
135135
{% if rel_link(permalink, suburl) == "#" %}

‎nikola/data/themes/bootstrap3/templates/base.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ ${template_hooks['extra_head']()}
1616
<nav class="navbar navbar-inverse navbar-static-top" role="navigation">
1717
<div class="container"><!-- This keeps the margins nice -->
1818
<div class="navbar-header">
19-
<button type="button" class="navbar-toggle" data-toggle="collapse" data-target=".navbar-ex1-collapse">
19+
<button type="button" class="navbar-toggle" data-toggle="collapse" data-target=".navbar-ex1-collapse" aria-expanded="false">
2020
<span class="sr-only">Toggle navigation</span>
2121
<span class="icon-bar"></span>
2222
<span class="icon-bar"></span>

‎nikola/data/themes/bootstrap3/templates/base_helper.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ lang="${lang}">
129129
<%def name="html_navigation_links()">
130130
%for url, text in navigation_links[lang]:
131131
% if isinstance(url, tuple):
132-
<li class="dropdown"><a href="#" class="dropdown-toggle" data-toggle="dropdown">${text} <b class="caret"></b></a>
132+
<li class="dropdown"><a href="#" class="dropdown-toggle" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">${text} <b class="caret"></b></a>
133133
<ul class="dropdown-menu">
134134
%for suburl, text in url:
135135
% if rel_link(permalink, suburl) == "#":

0 commit comments

Comments
 (0)
Please sign in to comment.