Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove org.modeshape.jcr hacks #834

Closed
wants to merge 7 commits into from
Closed

Remove org.modeshape.jcr hacks #834

wants to merge 7 commits into from

Conversation

acoburn
Copy link
Contributor

@acoburn acoburn commented Jul 10, 2015

public class GetBinaryStore implements Function<Repository, BinaryStore> {

private static final Logger LOGGER =
getLogger(GetBinaryStore.class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this line broken?

@ajs6f
Copy link
Contributor

ajs6f commented Jul 12, 2015

I love the fact that there are so many more deletions here than additions. That really makes me happy, seriously.

  * Added unit tests for FedoraTypesUtils::isExternalNode
  * Made GetCacheManager class package-protected
  * Removed GetBinaryStore class, as it can be inlined in GetClusterConfiguration class
@acoburn
Copy link
Contributor Author

acoburn commented Jul 13, 2015

@ajs6f I tightened the implementation, and there are now even more deletions (and fewer additions)

class GetCacheManager implements Function<Repository, CacheManager> {

private static final Logger LOGGER =
getLogger(GetCacheManager.class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't get the line break here. Is your editor set to break at 80 chars or something?

@ajs6f
Copy link
Contributor

ajs6f commented Jul 13, 2015

The code looks rad. But seriously, is your editor config'd funny? All the lines are really short.

@acoburn
Copy link
Contributor Author

acoburn commented Jul 13, 2015

@ajs6f lines are stretched out now

@ajs6f
Copy link
Contributor

ajs6f commented Jul 13, 2015

Yay! I'm good with this. I'll let @awoods review and merge, since there is no reviewer on the ticket.

@awoods
Copy link

awoods commented Jul 13, 2015

Resolved with:
e613e6b and
fabb0cc and
1c0156c

@awoods awoods closed this Jul 13, 2015
@acoburn acoburn deleted the fcrepo-1535 branch July 29, 2015 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants