New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove org.modeshape.jcr hacks #834
Conversation
public class GetBinaryStore implements Function<Repository, BinaryStore> { | ||
|
||
private static final Logger LOGGER = | ||
getLogger(GetBinaryStore.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this line broken?
I love the fact that there are so many more deletions here than additions. That really makes me happy, seriously. |
* Added unit tests for FedoraTypesUtils::isExternalNode * Made GetCacheManager class package-protected * Removed GetBinaryStore class, as it can be inlined in GetClusterConfiguration class
@ajs6f I tightened the implementation, and there are now even more deletions (and fewer additions) |
class GetCacheManager implements Function<Repository, CacheManager> { | ||
|
||
private static final Logger LOGGER = | ||
getLogger(GetCacheManager.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't get the line break here. Is your editor set to break at 80 chars or something?
The code looks rad. But seriously, is your editor config'd funny? All the lines are really short. |
@ajs6f lines are stretched out now |
Yay! I'm good with this. I'll let @awoods review and merge, since there is no reviewer on the ticket. |
See: https://jira.duraspace.org/browse/FCREPO-1535