Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 96608335862d
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 6036e4f5a833
Choose a head ref
  • 7 commits
  • 3 files changed
  • 4 contributors

Commits on Jul 10, 2015

  1. docs:events clarify emitter.listener() behavior 

    Clarifies that emitter.listener() returns a copy, not a reference
Resolves issue #9022

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25635
    @bsteephenson @jasnell
    bsteephenson authored and jasnell committed Jul 10, 2015
    Copy the full SHA
    f91fa52 View commit details
    Browse the repository at this point in the history

  2. doc: two minor stream doc improvements 

    per: #14596

1. document that a runtime error will occur if you attempt
   to unshift after the end event
2. document that calling read after the end event will return
   null and will not trigger a runtime error

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25635
    @jasnell
    jasnell committed Jul 10, 2015
    Copy the full SHA
    f7af915 View commit details
    Browse the repository at this point in the history

  3. doc: clarify Readable._read and Readable.push 

    Minor clarifications around Readable._read and Readable.push
to make their implementation/usage easier to understand.

#14124 (comment)

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25635
    @fresheneesz @jasnell
    fresheneesz authored and jasnell committed Jul 10, 2015
    Copy the full SHA
    9faae7a View commit details
    Browse the repository at this point in the history

  4. Update util.markdown 

    Fix for #25559 (Typo in example of util.deprecate() documentation)

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25635
    @danielrentz @jasnell
    danielrentz authored and jasnell committed Jul 10, 2015
    Copy the full SHA
    423c433 View commit details
    Browse the repository at this point in the history

  5. doc: stream.unshift does not reset reading state 

    Per #14604,

Document that performing an `unshift` during a read
can have unexpected results. Following the `unshift`
with a `push('')` resets the reading state appropriately.
Also indicate that doing an `unshift` during a read
is not optimal and should be avoided.

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25635
    @jasnell
    jasnell committed Jul 10, 2015
    Copy the full SHA
    daed421 View commit details
    Browse the repository at this point in the history

  6. doc: readable event clarification 

    per #14597

Indicate that `'readable'` indicates only that data can
be read from the stream, not that there is actually data
to be consumed. `readable.read([size])` can still return
null. Includes an example that illustrates the point.

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25635
    @jasnell
    jasnell committed Jul 10, 2015
    Copy the full SHA
    340e9f0 View commit details
    Browse the repository at this point in the history

  7. doc: additional refinement to readable event 

    Per #25635 (comment)

Additional refinement to the clarification on the `readable` event

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25635
    @jasnell
    jasnell committed Jul 10, 2015
    Copy the full SHA
    6036e4f View commit details
    Browse the repository at this point in the history