New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/depict - Part 2 (Reactions + Layouting) #160
Conversation
…ing methods for PDF/PS output that need to convert to PS Points (1/72 inch).
…ffset may be negative and we need to account for that.
…et the coordinates after invoking depict(IReaction).
…hreads. This is useful since we need to set the scale parameter before rendering, therefore even if the caller is good and doesn't change options during a run of depictions we have to! Note this is tricky since each parameter is an mutable instance we need to deep copy for every modification.
…e is we lay them out in a grid.
The images are not working for me... |
* Kenneth L. Kelly and Deanne B. Judd. | ||
* "Color: Universal Language and Dictionary of Names", | ||
* National Bureau of Standards, | ||
* Spec. Publ. 440, Dec. 1976, 189 pages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to put this in cheminf.bibx too and user {@cdk.cite ...}
A few minor comments which can be applied later.
Doh images aren't shareable from google. Odd because the last ones were |
Hopefully visible now but I think its google moving links.. probably to prevent hot linking. Here's the album link - https://goo.gl/photos/J99araookYzmTsa6A |
Part 2 - mainly tweaks to depiction classes (now immutable), reaction layout, and some long overdue patches to the SDG (allow it to handle fragments).
Rendering code hard to test as usual but added some for the layout updates.
Reaction Layout
Testing the removal of parts, here's the original...
No Agents...
Products Only...
Reactants Only...
Empty Reaction - (failed reaction)...
Agents only... it doesn't depict the arrow, actually I think that makes sense!
Atom Maps and Highlight
In the generator we turn on
withAtomMapNumbers()
orwithAtomMapHighlight()
to show the atom-mapping between reactants and products (supplied in the input SMILES).Salt Layout
By default, the SDG now lays out fragments of a molecule in a grid. If possible it tries to (re)bond ionic fragments before doing so with temporary bonds. Here's some results:
Sodium Benzoate
AlCl3
[Al+3].[Cl-].[Cl-].[Cl-]
K2CO3
[K+].[O-]C=O[O-][K+]
CHEMBL11933 - avoids the nitro