Fix redis erroring on non found blocks

Thanks to @netinetwalker for spotting the error, proposing a fix, and testing it. Error due to @est31's merging changes to PR #3202 to add more error reporting for invalid reply types, commit: 524a765 "redis: throw error if block request failed" Now we branch out on the valid reply type "not found".
minetest · Sep 26, 2015 · 4338f10 · 4338f10
1 parent 88a4412
commit 4338f10
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/database-redis.cpp b/src/database-redis.cpp
@@ -126,6 +126,11 @@ std::string Database_Redis::loadBlock(const v3s16 &pos)
 		throw FileNotGoodException(std::string(
 			"Redis command 'HGET %s %s' errored: ") + errstr);
 	}
+	case REDIS_REPLY_NIL: {
+		// block not found in database
+		freeReplyObject(reply);
+		return "";
+	}
 	}
 	errorstream << "loadBlock: loading block " << PP(pos)
 		<< " returned invalid reply type " << reply->type