Fixing #2109 (bug in get_asset_path). #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| None | ||
|
|
||
| >>> print(get_asset_path('nikola/nikola.py', ['bootstrap3', 'base'], {'nikola': 'nikola'})) | ||
| /.../nikola/nikola.py |
There was a problem hiding this comment.
/.../ stands for "some random path on my hdd which I don't want to paste here", like in the already existing examples.
There was a problem hiding this comment.
that’s a doctest ellipsis, not a real path
There was a problem hiding this comment.
The others are actually doctests.
There was a problem hiding this comment.
Isn't the new one a doctest, too? Or is some special magic needed to make it a doctest as well?
There was a problem hiding this comment.
This is a doctest, as it begins with >>> — py.test should pick it up (whether or not doctests are good is another thing)
There was a problem hiding this comment.
And it passes; if I modify the path, doit doctest fails.
|
Thanks for fixing this Felix! |
ralsina
added a commit
that referenced
this pull request
Sep 23, 2015
Fixing #2109 (bug in get_asset_path).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2109. Also fixes a bug in the docstring, and adds one more example output to make clear what it really does.