[Truffle] Basics of yaml parsing #3345
Closed
+1,194
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,6 +10,7 @@ | |||
|
|
|||
| 'jruby.basedir' => '${basedir}/..' ) | |||
|
|
|||
| jar 'org.yaml:snakeyaml:1.14' | |||
There was a problem hiding this comment.
Not sure if we should add a concrete dependency like this. JRuby seems to lazily add it to the class path or something, but not sure where it gets it from.
| @@ -623,6 +635,13 @@ private void initializeConstants() { | |||
| Layouts.MODULE.getFields(encodingConverterClass).setConstant(node, "XML_TEXT_DECORATOR", EConvFlags.XML_TEXT_DECORATOR); | |||
| Layouts.MODULE.getFields(encodingConverterClass).setConstant(node, "XML_ATTR_CONTENT_DECORATOR", EConvFlags.XML_ATTR_CONTENT_DECORATOR); | |||
| Layouts.MODULE.getFields(encodingConverterClass).setConstant(node, "XML_ATTR_QUOTE_DECORATOR", EConvFlags.XML_ATTR_QUOTE_DECORATOR); | |||
|
|
|||
| Layouts.MODULE.getFields(objectClass).setConstant(node, "RUBY_REVISION", Constants.RUBY_REVISION); | |||
| @@ -1135,6 +1135,12 @@ public RubyNode visitDefsNode(org.jruby.ast.DefsNode node) { | |||
| } | |||
|
|
|||
| protected RubyNode translateMethodDefinition(SourceSection sourceSection, RubyNode classNode, String methodName, org.jruby.ast.Node parseTree, org.jruby.ast.ArgsNode argsNode, org.jruby.ast.Node bodyNode) { | |||
| // | |||
There was a problem hiding this comment.
Should be
// Psych calls method names generated from class hierarchies. We have Truffle::Psych, so we need to adapt
|
Looks good, where are the passing tests/specs? |
|
This is enough to run the examples in the documentation. I'll get emitting working, then the full set of tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge - work in progress but looking for an initial review from any of @eregon, @pitr-ch or @nirvdrum please