-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for web audio api with basic nodes #43
Conversation
473fa75
to
2a82b25
Compare
|
||
def type=(type) | ||
unless TYPES.include?(type) | ||
fail ArgumentError, "type #{type} doesn't exists" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use #raise
instead of #fail
please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meh ok :)
Thanks! Added some comments that require changes. |
2a82b25
to
7064c68
Compare
@meh done :) |
|
||
if options | ||
`#@native.disconnect(#{other_node}, #{output}, #{input}) || nil` | ||
else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use elsif
and else
here.
Added some more comments about stuff I didn't notice earlier, it should be fine then. |
7064c68
to
d7ecadf
Compare
@meh added the getter methods |
|
||
if options | ||
`#@native.disconnect(#{other_node}, #{output}, #{input}) || nil` | ||
elsif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant elsif other_node
and else
, to flatten the logic, I don't think this is correct syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meh i'm sorry about this 😅 i have no excuse for this one 😑
d7ecadf
to
d87a4df
Compare
Merged, thanks 🐼 |
No description provided.