Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for web audio api with basic nodes #43

Closed
wants to merge 1 commit into from

Conversation

merongivian
Copy link
Contributor

No description provided.


def type=(type)
unless TYPES.include?(type)
fail ArgumentError, "type #{type} doesn't exists"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use #raise instead of #fail please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meh ok :)

@meh
Copy link
Member

meh commented Sep 22, 2015

Thanks! Added some comments that require changes.

@merongivian
Copy link
Contributor Author

@meh done :)


if options
`#@native.disconnect(#{other_node}, #{output}, #{input}) || nil`
else
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use elsif and else here.

@meh
Copy link
Member

meh commented Sep 22, 2015

Added some more comments about stuff I didn't notice earlier, it should be fine then.

@merongivian
Copy link
Contributor Author

@meh added the getter methods


if options
`#@native.disconnect(#{other_node}, #{output}, #{input}) || nil`
elsif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant elsif other_node and else, to flatten the logic, I don't think this is correct syntax.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meh i'm sorry about this 😅 i have no excuse for this one 😑

@meh
Copy link
Member

meh commented Sep 23, 2015

Merged, thanks 🐼

@meh meh closed this Sep 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants