Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File.file?( "uri:classloader:/path/") can be true which is wrong #3342

Closed
mkristian opened this issue Sep 21, 2015 · 0 comments
Closed

File.file?( "uri:classloader:/path/") can be true which is wrong #3342

mkristian opened this issue Sep 21, 2015 · 0 comments
Assignees
@mkristian
Labels
core embed
Milestone
JRuby 1.7.23

Comments

@mkristian
Copy link
Member 

java -jar jruby-complete.jar -e 'p File.file?("uri:classloader:/META-INF/jruby.home/")'
true

which is clearly directory and not a file. and

java -jar jruby-complete.jar -e 'p File.file?("uri:classloader:/META-INF/jruby.home")'
false
mkristian added a commit that referenced this issue Sep 22, 2015
@mkristian
make sure we contruct the path correctly when testing on isDirectory
5302de7 
this is only an issue with uri:classloader:/ and a classloader setup
where the .jrubydir needs to be loaded to treat the path as directory

fixes #3342

Sponsored by Lookout Inc.
@enebo enebo added this to the JRuby 1.7.23 milestone Oct 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkristian mkristian

Labels
core embed
Projects
None yet
Milestone
JRuby 1.7.23
Development

No branches or pull requests
3 participants
@enebo @rtyler @mkristian