This repository has been archived by the owner on Jan 23, 2022. It is now read-only.
PDLA::Lite exports match documentation, and update documentation #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise only the first caller would have these functions loaded, and it would thus not match the documentation. This issue has been around for a long time, as it pre-dates the addition of the package statement in 87487f0 . Also update the documentation to be clear about which methods are exported, and encourage the method calling syntax regardless. An alternative is to export nothing and document the method syntax as the only approach, but that would lead to CPAN breakage for those that rely on pdl() etc being exported (albeit such packages will not work if they are loaded second anyway). Updates issue PDLPorters#11
Update issue PDLPorters#11
|
Thanks for this! Is it possible to make your I see you're doing |
Updates issue PDLPorters#11
updates issue PDLPorters#11
|
No worries. I've replaced Devel::Symdump with ->can calls. The exporter issue was just cargo culting, and has been simplified to only use PDL::Exporter. Regards, |
wchristian
pushed a commit
to PDLPorters/pdl
that referenced
this pull request
Apr 30, 2017
Thanks to Shawn Laffan for the patch. Please see the original discussion at the PDLPorter/pdls-core github pull request PDLPorters/pdla-core#12
d-lamb
pushed a commit
to PDLPorters/pdl
that referenced
this pull request
Jan 19, 2019
Thanks to Shawn Laffan for the patch. Please see the original discussion at the PDLPorter/pdls-core github pull request PDLPorters/pdla-core#12
|
This has now been superceded by patches brought across from legacy PDL, plus a tweak or two. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message in 2233aa1 for details.
If it's approved then it might be worth squashing it all into one commit.
Updates issue #11
Regards,
Shawn.