Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if no context set in request, use context.TODO() #1502

Merged
merged 1 commit into from
Jul 21, 2015
Merged

if no context set in request, use context.TODO() #1502

merged 1 commit into from
Jul 21, 2015
+10 −0

Conversation

whyrusleeping
Copy link
Member

License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com

@whyrusleeping
if no context set in request, use context.TODO()

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5873aa2 
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
@whyrusleeping whyrusleeping added the status/in-progress In progress label Jul 21, 2015
@jbenet
Copy link
Member

jbenet commented Jul 21, 2015

@whyrusleeping let's maybe add a test that uses ipfs-shell ?

jbenet added a commit that referenced this pull request Jul 21, 2015
@jbenet
Merge pull request #1502 from ipfs/hotfix/nil-ctx

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d37ecbb 
if no context set in request, use context.TODO()
@jbenet jbenet merged commit d37ecbb into master Jul 21, 2015
@jbenet jbenet removed the status/in-progress In progress label Jul 21, 2015
@jbenet jbenet deleted the hotfix/nil-ctx branch July 21, 2015 04:51
@jbenet jbenet modified the milestone: IPFS 0.3.6 Jul 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
IPFS 0.3.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@whyrusleeping @jbenet