Feat/proto ping #1472
Merged
Feat/proto ping #1472
+187
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
feat/proto-ping
branch
2 times, most recently
from
c5cc4c1 to
8c82130
Compare
| case <-time.After(time.Second * 4): | ||
| t.Fatal("failed to receive ping") | ||
| } | ||
|
|
There was a problem hiding this comment.
i think this test needs to:
- ping in both directions as the test did before
- try pinging multiple times in a row
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
feat/proto-ping
branch
from
8c82130 to
a19ad97
Compare
|
@jbenet the test has been betterified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some dht cleanup and moving ping into its own protocol.