fix race introduced in bitswap #1474
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
|
Note: I would still like to find a way to publish the blocks before they get fully persisted to disk. That process can sometimes be slow and the getting blocks to the user faster allows the entire operation to progress more quickly |
|
whoops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing the publish before the
blockstore.Putwould cause a race where callers ofGetBlock(in tests) would finish, and then immediately try to read the blocks from the blockstore to verify that the block was received, and the block hadnt quite made it to disk yet by the time that call was made.repro was running:
for a few minutes, before the fix would fail within a minute, after the fix, ran for ten minutes before i got bored and killed it.
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com