fix parsing for paths of format <hash>/path #1475
Merged
+50
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
|
On Tue, Jul 14, 2015 at 12:02:39PM -0700, Jeromy Johnson wrote:
We could do that before (because len(parts) > 3). This commit just $ ipfs object stat /a Anyhow, the change itself (and tests :) look good to me. |
| @@ -114,6 +114,19 @@ test_object_cmd() { | |||
| test_cmp hwfile hwfile_out | |||
| ' | |||
|
|
|||
| test_expect_success "ipfs object stat path succeeds" ' | |||
| ipfs object stat $(cat multi_patch)/a/b/c > obj_stat_out | |||
| ' | |||
There was a problem hiding this comment.
maybe add this specific case too?
ipfs object stat $(cat multi_patch)/a > obj_stat_out_a
|
LGTM. one comment above based on @wking's observation o/ |
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
|
LGTM 👍 |
jbenet
added a commit
that referenced
this pull request
Jul 14, 2015
fix parsing for paths of format <hash>/path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with this we can now do
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com