Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide sha256sums #3135

Closed
BanzaiMan opened this issue Jul 15, 2015 · 9 comments
Closed

Provide sha256sums #3135

BanzaiMan opened this issue Jul 15, 2015 · 9 comments

Comments

@BanzaiMan
Copy link
Member

I'm duplicating jruby/jruby.github.io#2, opened by @envygeeks for better visibility.

Jekyll just started providing official JRuby support but we ran into a snag with our Docker images and our Deb's in that our build system requires Sha256sums to confirm a download, can you please start providing sha256sum's of your builds please?

@BanzaiMan
Copy link
Member Author

(I disabled the issues on jruby/jruby.github.io, so the issue is no longer accessible.)

@headius
Copy link
Member

headius commented Jul 15, 2015

I assume there's some maven magic we can use to do this automatically, but I was unable to find a nice plugin. I suppose since we use ruby-maven now we could just calculate them as part of the dist logic, eh @mkristian?

@mkristian
Copy link
Member

mkristian commented Jul 15, 2015 via email

@envygeeks
Copy link

Sorry about posting it in the wrong spot, I had originally posted it here but moved it there because I thought it might be a website issue, thanks for moving it back and letting me know!

@enebo
Copy link
Member

enebo commented Jul 15, 2015

I think we can do this during post_process_artifacts task and use Ruby Digest for this. We do not need this to push artifacts to maven so this is just for what we push to S3 right?

@mkristian
Copy link
Member

to attach those checksums for maven-central is difficult. I added already something for binary zip and tar.gz but not for the source distributions. which again is less straight forward.

so I would appreciate to have all this be done in this 'post_process_artifacts' for S3 !

@enebo
Copy link
Member

enebo commented Jul 15, 2015

Next versions and these will get pushed to S3 and be reachable. I do not have any immediate plans to add these to the web UI at this point since it would require some UI/CSS changes. If that is important to anyone speak up now :)

@envygeeks
Copy link

It's semi-important to me but if you point me where to go, I'll be happy to pull request the changes, I don't expect you to do all the work because that would be unfair.

@enebo
Copy link
Member

enebo commented Jul 15, 2015

@envygeeks I am deluding myself...this is trivial...for someone I thought these were also on the nav bar. They are on downloads page itself so I will just fix this when I release. No PR Neccesary.

kares added a commit that referenced this issue Jul 17, 2015
* jruby-1_7: (36 commits)
  no need for "" + ...
  keep the test Java 6 compilable + more asserts
  method cache hash calc needs to acount for Proc
  support for matching proc-to-iface methods by arity
  improve resolving functional-interfaces
  avoid reflection in getFunctionalInterface
  some Java.getFunctionalInterfaceMethod asserts
  introduce a getFunctionalInterfaceMethod helper
  generix-ize some of JavaUtil's static helpers
  Make sure windows files generate signatures as part of post_process_artifacts
  Doh...how did this not get added
  Fixes #3135. Provide sha256 sums
  yet another multiple args proc-to-iface spec
  less deprecation warnings from implementation_spec
  clean + avoid deprecation warn in executor_spec
  less rspec deprecation warnings from ant spec
  avoid File#listFiles in spec since it's ambiguous
  spec for regression in proc to iface optimization
  Fix references to old mailing lists.
  Return nil when waitpid returns 0. Fixes #3117.
  ...

Conflicts:
	VERSION
	antlib/extra.xml
	core/pom.xml
	core/src/main/java/org/jruby/RubyProcess.java
	core/src/main/java/org/jruby/embed/util/SystemPropertyCatcher.java
	core/src/test/java/org/jruby/embed/ScriptingContainerTest.java
	docs/man/pom.xml
	docs/pom.xml
	ext/pom.xml
	ext/readline/pom.xml
	ext/ripper/pom.xml
	lib/pom.xml
	maven/jruby-complete/pom.xml
	maven/jruby-dist/pom.xml
	maven/jruby-dist/src/main/assembly/jruby.xml
	maven/jruby-jars/pom.xml
	maven/jruby-noasm/pom.xml
	maven/jruby-rake-plugin/pom.xml
	maven/jruby-stdlib/pom.xml
	maven/jruby/pom.xml
	maven/pom.xml
	pom.xml
	test/pom.xml
	test/test_backquote.rb
	test/test_kernel.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants