-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JRuby trying to load jit'd code from Jars #3147
Comments
Hmm...this looks like logic to try to load a dumped version of each jitted method. It should not be doing this normally. Thanks for this report; this could indicate a lot of slow searching for classes that will never be found, bogging down the JIT. I will investigate. |
Is it possible to get a backtrace from one of these searches? I can probably fix this in seconds with that, but I'm having trouble locating where these loads might be happening. |
I can trace based off class names, including with a wildcard. What classes would you like to see ? |
Actually nevermind, I think I've found it! It appears we have code in ClassCache that attempts to load previously-dumped jitted methods from classloaders. If that fails, it proceeds on to define the jitted code as a new class. If it succeeds...it proceeds on to define the jitted code as a new class. So this searching is completely unnecessary, and never worked anyway because JIT dumping was never really finished as a concept in 1.7. I think our best move would be to simply remove all half-baked JIT dumping and this logic will disappear along with it. |
Sounds great, let me know if there is any way I can help you with testing out the fix. |
I have started a snapshot build of JRuby 1.7.22 (1.7 HEAD) that has the fix. Basically I just removed all JIT code cache logic because it was half-baked and not working anyway (but it still attempted the classloader search). When the 1.7.22-SNAPSHOT builds update on ci.jruby.org, grab it and confirm it's working. |
The build in question: https://projectodd.ci.cloudbees.com/view/JRuby/job/jruby-1.7-dist/324/ |
Optimistically marking this one as fixed. Do let us know when you're able to confirm it. |
I downloaded your snapshot and changed my
During trinidad startup I see I am using your snapshot
Using intrace I am still seeing calls to load
|
I should clarify: I'm seeing less class loading of |
Is there a chance of this getting fixed for 1.7.22 ? It seems as though perhaps there is just one last section of code trying to load a |
Hi, I'm using JRuby to run a rails app.
I traced JRuby 1.7.19 with InTrace. Each request I see many attempts to load classes from Jars like this. This is just one of the classes. None of them are ever found in a Jar. This doesn't seem like something that would be found in a jar file ever.
Is this a behavior of JRuby or of Java? Is there anyway I can suppress it searching the filesystem for these classes?
The text was updated successfully, but these errors were encountered: