New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup in fcrepo-http-api #835
Conversation
It looks like Travis is failing with javadoc errors: |
Fixed, I think. Try again. |
Now Travis is saying there is a checkstyle error: Before submitting a PR, I would suggest running the following three commands:
|
If that is the normal build check set, you need to actually key that into Maven. It's not hard to do that. Most people are going to expect that |
@ajs6f, the history here is that we used to have the javadoc plugin activated by default in the top-level pom.xml. Then, since we did not want to generate javadocs on each build, we moved the plugin into the release profile. Then, when we moved to Java8, javadoc errors became strictly enforced. I am happy to make changes if you have a suggestion, however. |
We moved the Javadoc step out because it wasn't needed to build and took time. Now it is needed to build, so either we should stop strictly enforcing the Javadocs rules or it should be run for |
Sounds good. Please create a ticket to re-add javadoc in the build process. |
https://jira.duraspace.org/browse/FCREPO-1631