Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rubinius/rubinius
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: abab1ad6e8f0
Choose a base ref
...
head repository: rubinius/rubinius
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bef51ae3fe81
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Jul 14, 2015

  1. Updated Bundler to 1.10.5.

    brixen committed Jul 14, 2015
    Copy the full SHA
    bd7dfdc View commit details
  2. Fixed setting log file access permissions.

    Since the process umask can override our open permissions, we need to explicitly
    set the permissions.
    brixen committed Jul 14, 2015
    Copy the full SHA
    bef51ae View commit details
Showing with 6 additions and 1 deletion.
  1. +1 −1 gems_list.txt
  2. +5 −0 vm/util/logger.cpp
2 changes: 1 addition & 1 deletion gems_list.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
bundler-1.10.4.gem
bundler-1.10.5.gem
daedalus-core-0.5.0.gem
ffi2-generators-0.1.1.gem
json-1.8.3.gem
5 changes: 5 additions & 0 deletions vm/util/logger.cpp
Original file line number Diff line number Diff line change
@@ -302,6 +302,11 @@ namespace rubinius {
perms_ = va_arg(varargs, int);

logger_fd_ = ::open(path, LOGGER_OPEN_FLAGS, perms_);

// The umask setting will override our permissions for open().
if(chmod(path, perms_) < 0) {
logger::warn("%s: logger: unable to set mode: %s", strerror(errno), path);
}
}

FileLogger::~FileLogger() {