-
-
Notifications
You must be signed in to change notification settings - Fork 330
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: opal/opal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f5f2c5cb35d1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: opal/opal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a00188702fd1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 5 commits
- 3 files changed
- 2 contributors
Commits on Jul 18, 2015
-
Simplify Array#& implementation (follow MRI's algo)
Performance profile is unaffected by this change: $ bundle exec rake bench:report Benchmark Opal1 Opal2 benchmark/bm_array_intersection_numbers.rb 1.342 1.344 benchmark/bm_array_intersection_objects.rb 2.595 2.439 benchmark/bm_array_intersection_strings.rb 0.795 0.787 (Opal1 = master branch, Opal2 = array branch)
Configuration menu - View commit details
-
Copy full SHA for 6d172a5 - Browse repository at this point
Copy the full SHA 6d172a5View commit details -
Array#| acts as if using an intermediate hash to collect values
Performance not affected: $ bundle exec rake bench:report Benchmark Opal1 Opal2 benchmark/bm_array_union_numbers.rb 2.136 2.135 benchmark/bm_array_union_objects.rb 4.362 4.568 benchmark/bm_array_union_strings.rb 1.660 1.675 (Opal1 = master branch, Opal2 = array branch)
Configuration menu - View commit details
-
Copy full SHA for 96068c1 - Browse repository at this point
Copy the full SHA 96068c1View commit details -
Array#- doesn't remove an item with the same hash but not #eql?
Array#- removes an item identified as equivalent via #hash and #eql? Performance not affected: $ bundle exec rake bench:report Benchmark Opal1 Opal2 benchmark/bm_array_minus_numbers.rb 1.380 1.367 benchmark/bm_array_minus_objects.rb 2.468 2.474 benchmark/bm_array_minus_strings.rb 0.814 0.814 (Opal1 = master branch, Opal2 = array branch)
Configuration menu - View commit details
-
Copy full SHA for 570a482 - Browse repository at this point
Copy the full SHA 570a482View commit details -
Array#uniq uses eql? semantics
Performance is not affected: $ bundle exec rake bench:report Benchmark Opal1 Opal2 benchmark/bm_array_uniq_bang_numbers.rb 0.605 0.579 benchmark/bm_array_uniq_bang_objects.rb 1.073 1.270 benchmark/bm_array_uniq_bang_strings.rb 0.358 0.469 benchmark/bm_array_uniq_numbers.rb 0.554 0.539 benchmark/bm_array_uniq_objects.rb 1.108 1.302 benchmark/bm_array_uniq_strings.rb 0.358 0.456 (Opal1 = master branch, Opal2 = array branch)
Configuration menu - View commit details
-
Copy full SHA for c6f0b6c - Browse repository at this point
Copy the full SHA c6f0b6cView commit details -
Merge pull request #1014 from vais/array
Fix Array#|, Array#-, and Array#uniq RubySpec failures
Configuration menu - View commit details
-
Copy full SHA for a001887 - Browse repository at this point
Copy the full SHA a001887View commit details
There are no files selected for viewing