@whyrusleeping other stuff uses the notifier. i think it doesnt import it because it just matches the interface? (or something like that).

maybe we should find a better way? (that doesnt randomly fail under load?)

i think we just need to fix that test to not be time based. better mocking. i'm at fault for all the time-based tests.

it all has to do with the first part: https://travis-ci.org/ipfs/go-ipfs/jobs/71693808#L202 -- that's the problem.

@jbenet so do you think we need to try and fix the tests? and not vendor them externally?

• i'm +1 on external vendoring.
• but i'm also +1 on fixing the test.

update here? in light of other PR?

@jbenet sorry, been distracted from this one. can take a look at fixing these tests.

Or make it less frequent.

On a spare server, run:

cd $GOPATH/src/github.com/ipfs/go-ipfs/p2p/net/swarm
while true; do go test; sleep .5; done  

And characterize the mean of the fail frequency, then adjust https://github.com/ipfs/go-ipfs/blob/master/p2p/net/swarm/swarm_dial.go#L50 so that it will happen less frequently.

closing, old PR cleanup time.