make timing tests actually not run under CI #1499
Merged
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
| @@ -117,7 +115,7 @@ func TestDialWait(t *testing.T) { | |||
| defer s1.Close() | |||
|
|
|||
| s1.dialT = time.Millisecond * 300 // lower timeout for tests. | |||
| if travis.IsRunning() { | |||
| if ci.IsRunning() { | |||
There was a problem hiding this comment.
these were deliberate-- i wanted them to run on jenkins / not-travis
There was a problem hiding this comment.
ah, do you want it changed back then?
jbenet
added a commit
that referenced
this pull request
Jul 19, 2015
make timing tests actually not run under CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we were actually ignoring the
CIenvironment variable, and in some places werent actually checking it in a platform agnostic way.License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com