https://jira.duraspace.org/browse/FCREPO-1411 #836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return input.getPredicate().equals(RDF.type.asNode()) | ||
| && isManagedNamespace.apply(input.getObject().getNameSpace()); | ||
| } | ||
| })); | ||
| }.negate().and(not(isManagedTriple)::apply); |
There was a problem hiding this comment.
why not use Predicate::or(isManagedTriple).negate() here?
There was a problem hiding this comment.
Because I stared at this too long to understand it or care any more. Send me a PR that seems clearer to you and I will happily merge it.
There was a problem hiding this comment.
The whole mess of "isManagedFoot" and "isManagedEar" and specific type-tests needs to have the stuffing kicked out of it and beaten into something that makes some kind of sense, here and in the kernel.
|
Resolved with: 6e755b2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.duraspace.org/browse/FCREPO-1411