Allow passing strings to #public_constant and #private_constant #3470
+20
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a tiny patch that makes
#private_constant
and#public_constant
accept strings as arguments. The maintained constants table is dealing with symbols but these methods can take strings ; it's pretty common to passclass.name
as an argument.MRI is doing the symbol conversion even though the documentation sets "symbol" as the given argument.
The Active Record test suite doesn't run at all on Rubinius since
has_and_belongs_to_many
relies on this.Have a nice day.