Allow passing strings to #public_constant and #private_constant #3470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The maintained constants table is dealing with symbols but these methods can take strings as arguments ; it's pretty common to pass `class.name` as an argument.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a tiny patch that makes
#private_constantand#public_constantaccept strings as arguments. The maintained constants table is dealing with symbols but these methods can take strings ; it's pretty common to passclass.nameas an argument.MRI is doing the symbol conversion even though the documentation sets "symbol" as the given argument.
The Active Record test suite doesn't run at all on Rubinius since
has_and_belongs_to_manyrelies on this.Have a nice day.