Skip to content

Commit

Permalink
[Truffle] Add regressed MRI test excludes
Browse files Browse the repository at this point in the history
@bjfish
bjfish committed Jul 14, 2015
1 parent b994c1c commit 35153eb
Showing 21 changed files with 93 additions and 3 deletions.
4 changes: 4 additions & 0 deletions test/mri/excludes_truffle/PStoreTest.rb
View file
Original file line number Diff line number Diff line change
@@ -2,3 +2,7 @@
exclude :"test_changes_are_not_written_on_abort", "needs investigation"
exclude :"test_data_should_be_loaded_correctly_when_in_readonly_mode", "needs investigation"
exclude :"test_pstore_files_are_accessed_as_binary_files", "needs investigation"
exclude :"test_data_should_be_loaded_correctly_when_in_readwrite_mode", "needs investigation"
exclude :"test_nested_transaction_raises_error", "needs investigation"
exclude :"test_opening_new_file_in_readwrite_mode_should_result_in_empty_values", "needs investigation"
exclude :"test_thread_safe", "needs investigation"
5 changes: 5 additions & 0 deletions test/mri/excludes_truffle/REXMLTests/ContribTester.rb
View file
Original file line number Diff line number Diff line change
@@ -5,3 +5,8 @@
exclude :"test_raw_Terje_Elde", "needs investigation"
exclude :"test_xpath_03_TobiasReif", "needs investigation"
exclude :test_various_xpath, "needs investigation"
exclude :"test_external_entity", "needs investigation"
exclude :"test_less_than_in_element_content", "needs investigation"
exclude :"test_namespaces_in_attlist_tobias", "needs investigation"
exclude :"test_pos", "needs investigation"
exclude :"test_umlaut", "needs investigation"
23 changes: 23 additions & 0 deletions test/mri/excludes_truffle/REXMLTests/JaxenTester.rb
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
exclude :"test_axis", "needs investigation"
exclude :"test_basic", "needs investigation"
exclude :"test_basicupdate", "needs investigation"
exclude :"test_contents", "needs investigation"
exclude :"test_defaultNamespace", "needs investigation"
exclude :"test_fibo", "needs investigation"
exclude :"test_id", "needs investigation"
exclude :"test_jaxen24", "needs investigation"
exclude :"test_lang", "needs investigation"
exclude :"test_message", "needs investigation"
exclude :"test_moreover", "needs investigation"
exclude :"test_much_ado", "needs investigation"
exclude :"test_namespaces", "needs investigation"
exclude :"test_nitf", "needs investigation"
exclude :"test_numbers", "needs investigation"
exclude :"test_pi", "needs investigation"
exclude :"test_pi2", "needs investigation"
exclude :"test_simple", "needs investigation"
exclude :"test_testNamespaces", "needs investigation"
exclude :"test_text", "needs investigation"
exclude :"test_underscore", "needs investigation"
exclude :"test_web", "needs investigation"
exclude :"test_web2", "needs investigation"
1 change: 1 addition & 0 deletions test/mri/excludes_truffle/REXMLTests/LightParserTester.rb
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
exclude :"test_parsing", "needs investigation"
2 changes: 2 additions & 0 deletions test/mri/excludes_truffle/REXMLTests/SAX2Tester.rb
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
exclude :"test_char_ref_dom", "needs investigation"
exclude :"test_socket", "needs investigation"
exclude :"test_sax2", "needs investigation"
exclude :"test_ticket_68", "needs investigation"
1 change: 1 addition & 0 deletions test/mri/excludes_truffle/REXMLTests/TestIssuezillaParsing.rb
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
exclude :"test_rexml", "needs investigation"
3 changes: 3 additions & 0 deletions test/mri/excludes_truffle/REXMLTests/TestXPathBase.rb
View file
Original file line number Diff line number Diff line change
@@ -23,3 +23,6 @@
exclude :"test_ticket_70", "needs investigation"
exclude :"test_ticket_71", "needs investigation"
exclude :"test_translate", "needs investigation"
exclude :"test_abbreviated_step", "needs investigation"
exclude :"test_lang", "needs investigation"
exclude :"test_ticket_43", "needs investigation"
6 changes: 6 additions & 0 deletions test/mri/excludes_truffle/REXMLTests/Tester.rb
View file
Original file line number Diff line number Diff line change
@@ -20,3 +20,9 @@
exclude :"test_ticket_85", "needs investigation"
exclude :"test_ticket_91", "needs investigation"
exclude :"test_tutorial", "needs investigation"
exclude :"test_doctype", "needs investigation"
exclude :"test_document", "needs investigation"
exclude :"test_source", "needs investigation"
exclude :"test_stream", "needs investigation"
exclude :"test_ticket_63", "needs investigation"
exclude :"test_ticket_75", "needs investigation"
8 changes: 8 additions & 0 deletions test/mri/excludes_truffle/TestConditionVariable.rb
View file
Original file line number Diff line number Diff line change
@@ -4,3 +4,11 @@
exclude :test_condvar_wait_deadlock, "spawn"
exclude :test_dup, "needs investigation"
exclude :test_dump, "Binding#eval"
exclude :"test_condvar_empty_broadcast", "needs investigation"
exclude :"test_condvar_empty_signal", "needs investigation"
exclude :"test_condvar_nolock", "needs investigation"
exclude :"test_condvar_nolock_2", "needs investigation"
exclude :"test_condvar_nolock_3", "needs investigation"
exclude :"test_condvar_signal_and_wait", "needs investigation"
exclude :"test_condvar_timed_wait", "needs investigation"
exclude :"test_initialized", "needs investigation"
1 change: 1 addition & 0 deletions test/mri/excludes_truffle/TestEncodingConverter.rb
View file
Original file line number Diff line number Diff line change
@@ -55,3 +55,4 @@
exclude :test_invalid_utf32le, "needs investigation"
exclude :test_iso2022jp_decode, "needs investigation"
exclude :test_putback, "needs investigation"
exclude :"test_default_external", "needs investigation"
15 changes: 15 additions & 0 deletions test/mri/excludes_truffle/TestFile.rb
View file
Original file line number Diff line number Diff line change
@@ -13,3 +13,18 @@
exclude :test_utime_with_minus_time_segv, "needs investigation"
exclude :test_stat, "needs investigation"
exclude :test_eof_1, "needs investigation"
exclude :"test_truncate_size", "needs investigation"
exclude :"test_each_byte_extended_file", "needs investigation"
exclude :"test_each_char_extended_file", "needs investigation"
exclude :"test_empty_file_bom", "needs investigation"
exclude :"test_eof_0_rw", "needs investigation"
exclude :"test_eof_1_seek", "needs investigation"
exclude :"test_eof_2", "needs investigation"
exclude :"test_file_open_permissions", "needs investigation"
exclude :"test_getbyte_extended_file", "needs investigation"
exclude :"test_getc_extended_file", "needs investigation"
exclude :"test_gets_extended_file", "needs investigation"
exclude :"test_read_all_extended_file", "needs investigation"
exclude :"test_truncate_beyond_eof", "needs investigation"
exclude :"test_truncate_rbuf", "needs investigation"
exclude :"test_truncate_wbuf", "needs investigation"
2 changes: 2 additions & 0 deletions test/mri/excludes_truffle/TestJSONFixtures.rb
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
exclude :"test_failing", "needs investigation"
exclude :"test_passing", "needs investigation"
7 changes: 6 additions & 1 deletion test/mri/excludes_truffle/TestLogger.rb
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
exclude :test_close, "needs investigation"
exclude :test_lshift, "needs investigation"
exclude :test_lshift, "needs investigation"
exclude :"test_add", "needs investigation"
exclude :"test_datetime_format", "needs investigation"
exclude :"test_format", "needs investigation"
exclude :"test_formatter", "needs investigation"
exclude :"test_level_log", "needs investigation"
6 changes: 6 additions & 0 deletions test/mri/excludes_truffle/TestMonitor.rb
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
exclude :"test_cond", "needs investigation"
exclude :"test_enter", "needs investigation"
exclude :"test_killed_thread_in_synchronize", "needs investigation"
exclude :"test_synchronize", "needs investigation"
exclude :"test_timedwait", "needs investigation"
exclude :"test_try_enter", "needs investigation"
1 change: 1 addition & 0 deletions test/mri/excludes_truffle/TestMutexM.rb
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
exclude :"test_cv_wait", "needs investigation"
1 change: 1 addition & 0 deletions test/mri/excludes_truffle/TestNotImplement.rb
View file
Original file line number Diff line number Diff line change
@@ -3,3 +3,4 @@
exclude :test_respond_to_fork, "needs investigation"
exclude :test_respond_to_lchmod, "needs investigation"
exclude :test_call_lchmod, "needs investigation"
exclude :"test_call_fork", "needs investigation"
1 change: 1 addition & 0 deletions test/mri/excludes_truffle/TestResolvAddr.rb
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
exclude :"test_invalid_byte_comment", "needs investigation"
1 change: 1 addition & 0 deletions test/mri/excludes_truffle/TestScanfBlock.rb
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
exclude :"test_io1", "needs investigation"
1 change: 1 addition & 0 deletions test/mri/excludes_truffle/TestScanfIO.rb
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
exclude :"test_io", "needs investigation"
3 changes: 3 additions & 0 deletions test/mri/excludes_truffle/XPathTester.rb
View file
Original file line number Diff line number Diff line change
@@ -23,3 +23,6 @@
exclude :"test_ticket_70", "needs investigation"
exclude :"test_ticket_71", "needs investigation"
exclude :"test_translate", "needs investigation"
exclude :"test_abbreviated_step", "needs investigation"
exclude :"test_lang", "needs investigation"
exclude :"test_ticket_43", "needs investigation"
4 changes: 2 additions & 2 deletions test/mri_truffle.index
View file
Original file line number Diff line number Diff line change
@@ -83,7 +83,7 @@ ruby/test_signal.rb
# ruby/test_sleep.rb # cannot load such file -- etc
ruby/test_sprintf.rb

ruby/test_sprintf_comb.rb
# ruby/test_sprintf_comb.rb # almost all failing / regression
ruby/test_string.rb
ruby/test_stringchar.rb
ruby/test_struct.rb
@@ -329,7 +329,7 @@ ripper/test_files.rb
# ripper/test_ripper.rb
# ripper/test_scanner_events.rb

scanf/test_scanf.rb
# scanf/test_scanf.rb # many failures / regression
scanf/test_scanfblocks.rb


3 comments on commit 35153eb

@bjfish
Copy link
Contributor Author

@bjfish bjfish commented on 35153eb Jul 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eregon @chrisseaton @nirvdrum I added these excludes to get the MRI tests passing again. There is also some regression when the test suite starts jt test mri:

ERROR IN TIMEOUT THREAD

    internal implementation error - UnsupportedOperationException Undefined Rubinius primitive. org.jruby.truffle.nodes.rubinius.UndefinedPrimitiveNodes$UndefinedPrimitiveNode.undefined(UndefinedPrimitiveNodes.java:34) (RubyTruffleError)

Backtrace:

/Users/brandonfish/Documents/jruby/test/mri/ruby/test_regexp.rb:557: warning: (VAliasNode 557) does nothing - translating as nil
/Users/brandonfish/Documents/jruby/test/mri/ruby/test_regexp.rb:558: warning: (VAliasNode 558) does nothing - translating as nil
/Users/brandonfish/Documents/jruby/test/mri/ruby/test_regexp.rb:559: warning: (VAliasNode 559) does nothing - translating as nil
/Users/brandonfish/Documents/jruby/test/mri/ruby/test_regexp.rb:560: warning: (VAliasNode 560) does nothing - translating as nil

@chrisseaton
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're being terrible about checking these MRI tests - thanks for catching up on them @bjfish.

@eregon
Copy link
Member

@eregon eregon commented on 35153eb Jul 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjfish Great, I'll enable them on Travis so we get quick feedback when we regress :)

Please sign in to comment.