Rename Float#negative? to Float#signbit?
#3469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 2.3 ships with a new `Numeric#negative?` method. Rubinius implements this method since b92c84f, for internal usage though ; it delegates to the signbit C++ function. However, `signbit`'s behavior can't match MRI `Float#negative?`'s one since the former operates on the sign while the latter operates on the value (see http://git.io/vm1fg).
|
Rebased into 533da7e, thanks! |
|
@robin850 if people are relying on checking a method for version, please direct them to https://github.com/brixen/redcard. We won't be fixing issues where people wrongly use methods or classes to infer the Ruby version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Ruby 2.3 ships with a new
Numeric#negative?method. Rubinius implements this method since b92c84f, for internal usage though ; it delegates to thesignbitC++ function.However,
signbit's behavior can't match MRIFloat#negative?'s one since the former operates on the sign while the latter operates on the value (see here).This makes a test to fail on the Rails test suite (the same example is present in the
signbit's documentation and -0.0 is considered negative this time).Moreover, if people rely on feature detection rather than version checking, they may wrongly assume that the current running Ruby is 2.3+ checking if a float respond to
#negative?.Have a nice day!