Rename Float#negative? to Float#signbit?

robin850 · Yorick Peterse · commit 533da7eadbf6 · 2015-07-18T14:15:16.000+02:00
Ruby 2.3 ships with a new `Numeric#negative?` method. Rubinius implements this method since b92c84f, for internal usage though ; it delegates to the signbit C++ function. However, `signbit`'s behavior can't match MRI `Float#negative?`'s one since the former operates on the sign while the latter operates on the value (see http://git.io/vm1fg).
diff --git a/kernel/common/complex.rb b/kernel/common/complex.rb
@@ -277,7 +277,7 @@ def rationalize(eps = nil)
   def to_s
     result = real.to_s
 
-    if imag.kind_of?(Float) ? !imag.nan? && imag.negative? : imag < 0
+    if imag.kind_of?(Float) ? !imag.nan? && imag.signbit? : imag < 0
       result << "-"
     else
       result << "+"
diff --git a/kernel/common/float.rb b/kernel/common/float.rb
@@ -57,7 +57,7 @@ def to_r
   def arg
     if nan?
       self
-    elsif negative?
+    elsif signbit?
       Math::PI
     else
       0
@@ -118,9 +118,9 @@ def abs
 
   alias_method :magnitude, :abs
 
-  def negative?
-    Rubinius.primitive :float_negative
-    raise PrimitiveFailure, "Float#negative primitive failed"
+  def signbit?
+    Rubinius.primitive :float_signbit_p
+    raise PrimitiveFailure, "Float#signbit? primitive failed"
   end
 
   def +(other)
diff --git a/vm/builtin/float.cpp b/vm/builtin/float.cpp
@@ -457,7 +457,7 @@ namespace rubinius {
     return String::create(state, str, sz);
   }
 
-  Object* Float::negative(STATE) {
+  Object* Float::signbit_p(STATE) {
     return signbit(this->val) ? cTrue : cFalse;
   }
 
diff --git a/vm/builtin/float.hpp b/vm/builtin/float.hpp
@@ -129,8 +129,8 @@ namespace rubinius {
     // Rubinius.primitive :float_to_packed
     String* to_packed(STATE, Object* want_double);
 
-    // Rubinius.primitive :float_negative
-    Object* negative(STATE);
+    // Rubinius.primitive :float_signbit_p
+    Object* signbit_p(STATE);
 
     static int radix()      { return FLT_RADIX; }
     static int rounds()     { return FLT_ROUNDS; }

Original file line number	Diff line number	Diff line change
`@@ -457,7 +457,7 @@ namespace rubinius {`
`457`	`457`	`return String::create(state, str, sz);`
`458`	`458`	`}`
`459`	`459`
`460`		`- Object* Float::negative(STATE) {`
	`460`	`+ Object* Float::signbit_p(STATE) {`
`461`	`461`	`return signbit(this->val) ? cTrue : cFalse;`
`462`	`462`	`}`
`463`	`463`